diff options
| author | Sean McGivern <sean@gitlab.com> | 2017-05-31 16:45:14 +0100 |
|---|---|---|
| committer | Sean McGivern <sean@gitlab.com> | 2017-06-01 10:21:26 +0100 |
| commit | 7f73f440f9a4a8761c083a6781d3c4015228d9b9 (patch) | |
| tree | 8119689770dfa79aaf1e77fc7c6d06a7b8b6cca2 /changelogs | |
| parent | 228926daee799c95e752a3c284c860e5bc60e528 (diff) | |
| download | gitlab-ce-7f73f440f9a4a8761c083a6781d3c4015228d9b9.tar.gz | |
Fix N+1 queries for non-members in comment threadsfix-n-plus-one-queries-for-user-access
When getting the max member access for a group of users, we stored the results
in RequestStore. However, this will only return results for project members, so
anyone who wasn't a member of the project would be checked once at the start,
and then once for each comment they made. These queries are generally quite
fast, but no query is faster!
Diffstat (limited to 'changelogs')
| -rw-r--r-- | changelogs/unreleased/fix-n-plus-one-queries-for-user-access.yml | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/changelogs/unreleased/fix-n-plus-one-queries-for-user-access.yml b/changelogs/unreleased/fix-n-plus-one-queries-for-user-access.yml new file mode 100644 index 00000000000..c2671a96b83 --- /dev/null +++ b/changelogs/unreleased/fix-n-plus-one-queries-for-user-access.yml @@ -0,0 +1,4 @@ +--- +title: Fix N+1 queries for non-members in comment threads +merge_request: +author: |