diff options
| author | Stan Hu <stanhu@gmail.com> | 2018-05-17 23:48:59 -0700 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2018-05-17 23:51:54 -0700 |
| commit | 6b98033d9120c7dfc5276f623e27e7af22dd7b88 (patch) | |
| tree | 732fdf915bf1cce184011c7bb3329e966b667d46 /changelogs | |
| parent | 4609a1268de9f15c02899c906cbb9ce27c495ab3 (diff) | |
| download | gitlab-ce-6b98033d9120c7dfc5276f623e27e7af22dd7b88.tar.gz | |
Fix api_json.log not always reporting the right HTTP status code
As described in https://github.com/aserafin/grape_logging/issues/45, if
a Grape error is caught by the handlers and a different return code
is returned, then the api_json.log would have a 500 error code
instead of the right value. Inserting the GrapeLogging middleware
after the Grape middleware fixes this problem.
Seen in https://gitlab.com/gitlab-com/infrastructure/issues/4249
Diffstat (limited to 'changelogs')
| -rw-r--r-- | changelogs/unreleased/sh-fix-grape-logging-status-code.yml | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/changelogs/unreleased/sh-fix-grape-logging-status-code.yml b/changelogs/unreleased/sh-fix-grape-logging-status-code.yml new file mode 100644 index 00000000000..aabf9a84bfb --- /dev/null +++ b/changelogs/unreleased/sh-fix-grape-logging-status-code.yml @@ -0,0 +1,5 @@ +--- +title: Fix api_json.log not always reporting the right HTTP status code +merge_request: +author: +type: fixed |