diff options
| author | Stan Hu <stanhu@gmail.com> | 2019-02-26 14:40:13 -0800 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2019-02-26 17:00:58 -0800 |
| commit | 7765e6ec108f1c159e5b38d2048d4095861f6288 (patch) | |
| tree | 0742e2a53591f68db52a35982e1497295fd0ad5a /changelogs | |
| parent | 3b05d4817bdef0bb34de2d6b6984e81c7aae3a16 (diff) | |
| download | gitlab-ce-7765e6ec108f1c159e5b38d2048d4095861f6288.tar.gz | |
Fix pagination and duplicate requests in environments page
This commit fixes two problems:
1. When a user clicked on another page, the app would fetch the new page
data but never update because the request and response parameters failed
to match the isEqual check. This was happening because the JSON response
omitted the `nested` attribute, so there was a comparison with a `null`
value. We fix this by scrubbing undefined values before doing the
comparison.
2. There were duplicate requests made for the environments page because
the success handler of fetchPipelines() would cause the polling
component to make another XHR request.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/58191
Diffstat (limited to 'changelogs')
| -rw-r--r-- | changelogs/unreleased/sh-wip-fix-duplicate-env-xhr.yml | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/changelogs/unreleased/sh-wip-fix-duplicate-env-xhr.yml b/changelogs/unreleased/sh-wip-fix-duplicate-env-xhr.yml new file mode 100644 index 00000000000..e7900e2230d --- /dev/null +++ b/changelogs/unreleased/sh-wip-fix-duplicate-env-xhr.yml @@ -0,0 +1,5 @@ +--- +title: Fix pagination and duplicate requests in environments page +merge_request: 25582 +author: +type: fixed |