summaryrefslogtreecommitdiff
path: root/changelogs
diff options
context:
space:
mode:
authorStan Hu <stanhu@gmail.com>2018-07-24 12:58:31 -0700
committerStan Hu <stanhu@gmail.com>2018-07-24 13:00:49 -0700
commitbe495c6a80fadd6c741b82c7e9d585f3f1ab349b (patch)
treeb03a82ca958aba4b17f64feaa76eafcdc26b3c03 /changelogs
parentc06e2ac888fb5180cdf133df89d03b99eceafa0d (diff)
downloadgitlab-ce-be495c6a80fadd6c741b82c7e9d585f3f1ab349b.tar.gz
Fix slow Markdown rendering
The sanitize transformers were being duplicated each time the Markdown renderer was called, leading to expontential growth in rendering times. The problem was that although HTML::Pipeline::SanitizationFilter.WHITELIST is a frozen hash, the `:transformers` array can be modified. We need to do deep copy of this to avoid adding duplicates. Closes #49409
Diffstat (limited to 'changelogs')
-rw-r--r--changelogs/unreleased/sh-revert-markdown-changes.yml5
1 files changed, 5 insertions, 0 deletions
diff --git a/changelogs/unreleased/sh-revert-markdown-changes.yml b/changelogs/unreleased/sh-revert-markdown-changes.yml
new file mode 100644
index 00000000000..72540f710a1
--- /dev/null
+++ b/changelogs/unreleased/sh-revert-markdown-changes.yml
@@ -0,0 +1,5 @@
+---
+title: Fix slow Markdown rendering
+merge_request: 20820
+author:
+type: performance