summaryrefslogtreecommitdiff
path: root/changelogs
diff options
context:
space:
mode:
authorBob Van Landuyt <bob@vanlanduyt.co>2018-12-07 18:09:00 +0100
committerBob Van Landuyt <bob@vanlanduyt.co>2018-12-17 18:47:53 +0100
commit28acd2b087d5b80cd89354d58f937aed0f4928cb (patch)
tree0eda3c8ee7be722d51a390c750f1fd39dd88276b /changelogs
parent75262862c434a98b9183a4a63f3ad86dec52b079 (diff)
downloadgitlab-ce-28acd2b087d5b80cd89354d58f937aed0f4928cb.tar.gz
Hide confidential events in ruby
We're filtering the events using `Event#visible_to_user?`. At most we're loading 100 events at once. Pagination is also dealt with in the finder, but the resulting array is wrapped in a `Kaminari.paginate_array` so the API's pagination helpers keep working. We're passing the total count into that paginatable array, which would include confidential events. But we're not disclosing anything.
Diffstat (limited to 'changelogs')
-rw-r--r--changelogs/unreleased/bvl-hide-confidential-events-take2.yml5
1 files changed, 5 insertions, 0 deletions
diff --git a/changelogs/unreleased/bvl-hide-confidential-events-take2.yml b/changelogs/unreleased/bvl-hide-confidential-events-take2.yml
new file mode 100644
index 00000000000..a5abd496a9d
--- /dev/null
+++ b/changelogs/unreleased/bvl-hide-confidential-events-take2.yml
@@ -0,0 +1,5 @@
+---
+title: Hide confidential events in the API
+merge_request: 23746
+author:
+type: other