diff options
| author | Stan Hu <stanhu@gmail.com> | 2017-04-23 22:32:50 -0700 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2017-04-24 06:43:24 -0700 |
| commit | a0edaa9210642f23ef3ea4984c6d6f77cbbba878 (patch) | |
| tree | 5c5eccfe23aaad3a1427fd7e9bd5992f44e98ac1 /changelogs | |
| parent | 1005389f70070245092c1ae5f3f9b10b8e7c102e (diff) | |
| download | gitlab-ce-a0edaa9210642f23ef3ea4984c6d6f77cbbba878.tar.gz | |
Cache Routable#full_path in RequestStore to reduce duplicate route loadssh-optimize-duplicate-routable-full-path
We see in #27387 that a call to `polymorphic_path` will cause duplicate
SELECT route calls for each merge request in a milestone. This happens
because calling `project.namespace.becomes(Namespace)` will instantiate
a new instance of a Namespace for each merge request, which causes a N+1
query on the routes table. This change caches the state of the route by
the specific class and ID, which dramatically eliminates duplicate work.
Diffstat (limited to 'changelogs')
| -rw-r--r-- | changelogs/unreleased/sh-optimize-duplicate-routable-full-path.yml | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/changelogs/unreleased/sh-optimize-duplicate-routable-full-path.yml b/changelogs/unreleased/sh-optimize-duplicate-routable-full-path.yml new file mode 100644 index 00000000000..b1ef00f09b2 --- /dev/null +++ b/changelogs/unreleased/sh-optimize-duplicate-routable-full-path.yml @@ -0,0 +1,4 @@ +--- +title: Cache Routable#full_path in RequestStore to reduce duplicate route loads +merge_request: +author: |