diff options
| author | Stan Hu <stanhu@gmail.com> | 2019-07-17 12:33:49 -0700 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2019-07-17 15:11:01 -0700 |
| commit | 9dd59df6991b9d82bcbb95bf406194aab8ecf743 (patch) | |
| tree | 8e1331802676781b266be121e8e228cb272fa054 /config | |
| parent | c11eb0c3a42dba550764e96426dd9bf21347b917 (diff) | |
| download | gitlab-ce-9dd59df6991b9d82bcbb95bf406194aab8ecf743.tar.gz | |
Fix inconsistency in Redis performance bar statssh-fix-redis-performance-bar
peek-redis resets its counters at the start of an ActionController
notification (`start_processing.action_controller`), which causes it to
miss some Redis queries that precede it, such as the database load
balancer and Rack Attack queries. This produces inconsistencies in the
performance bar between the number of calls and their durations with the
actual calls in the detailed view.
We fix this by getting rid of peek-redis in favor of consolidating all
logic into the `RedisDetailed` view, which tracks Redis queries using
`RequestStore`. This has the nice property of removing thread-specific
counters as well.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/64707
Diffstat (limited to 'config')
| -rw-r--r-- | config/initializers/peek.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/config/initializers/peek.rb b/config/initializers/peek.rb index d492b60705d..2aec32e878c 100644 --- a/config/initializers/peek.rb +++ b/config/initializers/peek.rb @@ -29,7 +29,7 @@ end Peek.into PEEK_DB_VIEW Peek.into Peek::Views::Gitaly Peek.into Peek::Views::Rblineprof -Peek.into Peek::Views::Redis +Peek.into Peek::Views::RedisDetailed Peek.into Peek::Views::GC Peek.into Peek::Views::Tracing if Labkit::Tracing.tracing_url_enabled? |