summaryrefslogtreecommitdiff
path: root/danger/commit_messages
diff options
context:
space:
mode:
authorPaul Slaughter <pslaughter@gitlab.com>2019-01-11 01:05:46 -0600
committerPaul Slaughter <pslaughter@gitlab.com>2019-01-11 07:33:02 -0600
commit193f764bc2934b32775d22ba320fa4ac5acc9634 (patch)
tree06df1e099c2a8eb4d4126a15deb68aa6425f657f /danger/commit_messages
parent89c4d2ae623dbd666e2eaa58812323b81e02b4ea (diff)
downloadgitlab-ce-193f764bc2934b32775d22ba320fa4ac5acc9634.tar.gz
Shorten danger 50 char commit warning
- Also pulls URLs into vars
Diffstat (limited to 'danger/commit_messages')
-rw-r--r--danger/commit_messages/Dangerfile10
1 files changed, 5 insertions, 5 deletions
diff --git a/danger/commit_messages/Dangerfile b/danger/commit_messages/Dangerfile
index 6a5a75b6eba..691dbbab184 100644
--- a/danger/commit_messages/Dangerfile
+++ b/danger/commit_messages/Dangerfile
@@ -14,6 +14,9 @@ class EmojiChecker
DIGESTS = File.expand_path('../../fixtures/emojis/digests.json', __dir__)
ALIASES = File.expand_path('../../fixtures/emojis/aliases.json', __dir__)
+ URL_LIMIT_SUBJECT = "https://chris.beams.io/posts/git-commit/#limit-50"
+ URL_GIT_COMMIT = "https://chris.beams.io/posts/git-commit/"
+
# A regex that indicates a piece of text _might_ include an Emoji. The regex
# alone is not enough, as we'd match `:foo:bar:baz`. Instead, we use this
# regex to save us from having to check for all possible emoji names when we
@@ -101,10 +104,7 @@ def lint_commits(commits)
elsif subject.length > 50
warn_commit(
commit,
- "This commit's subject line could be improved. " \
- 'Commit subjects are ideally no longer than roughly 50 characters, ' \
- 'though we allow up to 72 characters in the subject. ' \
- 'If possible, try to reduce the length of the subject to roughly 50 characters.'
+ "This commit's subject line is acceptable, but please try to [reduce it to 50 characters](#{URL_LIMIT_SUBJECT})."
)
end
@@ -196,7 +196,7 @@ def lint_commits(commits)
One or more commit messages do not meet our Git commit message standards.
For more information on how to write a good commit message, take a look at
- [How to Write a Git Commit Message](https://chris.beams.io/posts/git-commit/).
+ [How to Write a Git Commit Message](#{URL_GIT_COMMIT}).
Here is an example of a good commit message: