diff options
| author | Ash McKenzie <amckenzie@gitlab.com> | 2019-09-06 07:14:30 +0000 |
|---|---|---|
| committer | Ash McKenzie <amckenzie@gitlab.com> | 2019-09-06 07:14:30 +0000 |
| commit | f34e4545ec20953267ee187227116756562c6e8a (patch) | |
| tree | 32326de09418e404ac74b2b05398bd5449ba8b6c /danger/duplicate_yarn_dependencies | |
| parent | 351d72cbed57c5b117e6b2239dffabcedbc45046 (diff) | |
| download | gitlab-ce-f34e4545ec20953267ee187227116756562c6e8a.tar.gz | |
Revert "Merge branch '66596-allow-danger-to-be-run-locally' into 'master'"revert-351d72cb
This reverts merge request !32196
Diffstat (limited to 'danger/duplicate_yarn_dependencies')
| -rw-r--r-- | danger/duplicate_yarn_dependencies/Dangerfile | 24 |
1 files changed, 11 insertions, 13 deletions
diff --git a/danger/duplicate_yarn_dependencies/Dangerfile b/danger/duplicate_yarn_dependencies/Dangerfile index 492b888d00e..25f81ec86a4 100644 --- a/danger/duplicate_yarn_dependencies/Dangerfile +++ b/danger/duplicate_yarn_dependencies/Dangerfile @@ -1,6 +1,6 @@ # frozen_string_literal: true -return unless helper.all_changed_files.include?('yarn.lock') +return unless helper.all_changed_files.include? 'yarn.lock' duplicate = `node_modules/.bin/yarn-deduplicate --list --strategy fewer yarn.lock` .split(/$/) @@ -11,19 +11,17 @@ return if duplicate.empty? warn 'This merge request has introduced duplicated yarn dependencies.' -if GitlabDanger.new(helper.gitlab_helper).ci? - markdown(<<~MARKDOWN) - ## Duplicate yarn dependencies +markdown(<<~MARKDOWN) + ## Duplicate yarn dependencies - The following dependencies should be de-duplicated: + The following dependencies should be de-duplicated: - * #{duplicate.map { |path| "`#{path}`" }.join("\n* ")} + * #{duplicate.map { |path| "`#{path}`" }.join("\n* ")} - Please run the following command and commit the changes to `yarn.lock`: + Please run the following command and commit the changes to `yarn.lock`: - ``` - node_modules/.bin/yarn-deduplicate --strategy fewer yarn.lock \\ - && yarn install - ``` - MARKDOWN -end + ``` + node_modules/.bin/yarn-deduplicate --strategy fewer yarn.lock \\ + && yarn install + ``` +MARKDOWN |