diff options
author | Rémy Coutable <remy@rymai.me> | 2018-05-21 18:41:21 +0200 |
---|---|---|
committer | Rémy Coutable <remy@rymai.me> | 2018-07-11 11:52:01 +0200 |
commit | 5679837cd412c2fb7911dcb33c19e89d8a787db0 (patch) | |
tree | fe9984ff05042df9ec0fc6de59e85171e337866d /danger/metadata | |
parent | d2ea56a87026de92f31bbcfb360748fcf766b835 (diff) | |
download | gitlab-ce-5679837cd412c2fb7911dcb33c19e89d8a787db0.tar.gz |
Start to use Danger for automating MR reviews
Signed-off-by: Rémy Coutable <remy@rymai.me>
Diffstat (limited to 'danger/metadata')
-rw-r--r-- | danger/metadata/Dangerfile | 25 |
1 files changed, 25 insertions, 0 deletions
diff --git a/danger/metadata/Dangerfile b/danger/metadata/Dangerfile new file mode 100644 index 00000000000..033a84d6ecd --- /dev/null +++ b/danger/metadata/Dangerfile @@ -0,0 +1,25 @@ +# rubocop:disable Style/SignalException + +if gitlab.mr_body.size < 5 + fail "Please provide a merge request description." +end + +if gitlab.mr_labels.empty? + fail "Please add labels to this merge request." +end + +unless gitlab.mr_json["assignee"] + warn "This merge request does not have any assignee yet. Setting an assignee clarifies who needs to take action on the merge request at any given time." +end + +has_milestone = !gitlab.mr_json["milestone"].nil? + +unless has_milestone + warn "This merge request does not refer to an existing milestone.", sticky: false +end + +has_pick_into_stable_label = gitlab.mr_labels.find { |label| label.start_with?('Pick into') } + +if gitlab.branch_for_base != "master" && !has_pick_into_stable_label + fail "All merge requests should target `master`. Otherwise, please set the relevant `Pick into X.Y` label." +end |