diff options
| author | Rémy Coutable <remy@rymai.me> | 2018-07-10 12:10:54 +0200 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2018-07-11 11:52:03 +0200 |
| commit | ab87e7bab1d5cc20c7b69644843bfcb1f3f16918 (patch) | |
| tree | 2f908718378fbe6984d65781ea76c623ace57eb6 /danger/specs | |
| parent | dc629bb6b8146477fdbf9fcd11d10ebedc785029 (diff) | |
| download | gitlab-ce-ab87e7bab1d5cc20c7b69644843bfcb1f3f16918.tar.gz | |
Improve Danger files after first review
Signed-off-by: Rémy Coutable <remy@rymai.me>
Diffstat (limited to 'danger/specs')
| -rw-r--r-- | danger/specs/Dangerfile | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/danger/specs/Dangerfile b/danger/specs/Dangerfile index 88e64c57a4b..0ed5235ec02 100644 --- a/danger/specs/Dangerfile +++ b/danger/specs/Dangerfile @@ -1,13 +1,14 @@ # rubocop:disable Style/SignalException +NO_NEW_SPEC_MESSAGE = <<~MSG +You've made some app changes, but didn't add any tests. +That's OK as long as you're refactoring existing code, +but please consider adding the ~backstage label in that case. +MSG + has_app_changes = !git.modified_files.grep(%r{\A(ee/)?(app|lib|db/(geo/)?(post_)?migrate)/}).empty? has_spec_changes = !git.modified_files.grep(/spec/).empty? if has_app_changes && !has_spec_changes - msg = [ - "You've made some app changes, but didn't add any tests.", - "That's OK as long as you're refactoring existing code (please consider adding the ~backstage label in that case)." - ] - - warn msg.join(" "), sticky: false + warn NO_NEW_SPEC_MESSAGE, sticky: false end |