diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2021-09-03 15:10:48 +0000 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2021-09-03 15:10:48 +0000 |
commit | af7ba639ec0b6bba26adc244e8971d4113d2c041 (patch) | |
tree | e5369d7cd9aaaca075c21dd5d709501e78d1089d /danger | |
parent | 53ea1228bef63279e558b08b50144775f6f3a4c4 (diff) | |
download | gitlab-ce-af7ba639ec0b6bba26adc244e8971d4113d2c041.tar.gz |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'danger')
-rw-r--r-- | danger/karma/Dangerfile | 51 |
1 files changed, 0 insertions, 51 deletions
diff --git a/danger/karma/Dangerfile b/danger/karma/Dangerfile deleted file mode 100644 index e05bd86313f..00000000000 --- a/danger/karma/Dangerfile +++ /dev/null @@ -1,51 +0,0 @@ -# frozen_string_literal: true -# rubocop:disable Style/SignalException - -def get_karma_files(files) - files.select do |file| - file.start_with?('ee/spec/javascripts', 'spec/javascripts') && - file.end_with?('_spec.js') && - !file.end_with?('browser_spec.js') - end -end - -new_karma_files = get_karma_files(git.added_files.to_a) - -unless new_karma_files.empty? - - if helper.ci? - markdown(<<~MARKDOWN) - ## New karma spec file - - New frontend specs ([except `browser_specs`](https://gitlab.com/gitlab-org/gitlab/blob/3b6fe2f1077eedb0b8aff02a7350234f0b7dc4f9/spec/javascripts/lib/utils/browser_spec.js#L2)) should be - [written in jest](https://docs.gitlab.com/ee/development/testing_guide/frontend_testing.html#jest). - - You have created the following tests, please migrate them over to jest: - - * #{new_karma_files.map { |path| "`#{path}`" }.join("\n* ")} - MARKDOWN - end - - fail "You have created a new karma spec file" - -end - -changed_karma_files = get_karma_files(helper.all_changed_files) - new_karma_files - -return if changed_karma_files.empty? - -warn 'You have edited karma spec files. Please consider migrating them to jest.' - -if helper.ci? - markdown(<<~MARKDOWN) - ## Edited karma files - - You have edited the following karma spec files. Please consider migrating them to jest: - - * #{changed_karma_files.map { |path| "`#{path}`" }.join("\n* ")} - - In order to align with our Iteration value, migration can also be done as a follow-up. - - For more information: [Jestodus epic](https://gitlab.com/groups/gitlab-org/-/epics/895) - MARKDOWN -end |