diff options
author | Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | 2016-03-30 10:38:03 +0200 |
---|---|---|
committer | Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | 2016-03-30 10:44:20 +0200 |
commit | 1a293a43847b30d4357116f830a1b22d370c4a6f (patch) | |
tree | 06abae750f472c2555ccb7fa77d10432cb41bda7 /db/migrate/20160328115649_migrate_new_notification_setting.rb | |
parent | 065faac3a390f29b57db5261e9eab4efa076554c (diff) | |
download | gitlab-ce-1a293a43847b30d4357116f830a1b22d370c4a6f.tar.gz |
Update migration comment
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
Diffstat (limited to 'db/migrate/20160328115649_migrate_new_notification_setting.rb')
-rw-r--r-- | db/migrate/20160328115649_migrate_new_notification_setting.rb | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/db/migrate/20160328115649_migrate_new_notification_setting.rb b/db/migrate/20160328115649_migrate_new_notification_setting.rb index aff866b5f46..6a68890f5b1 100644 --- a/db/migrate/20160328115649_migrate_new_notification_setting.rb +++ b/db/migrate/20160328115649_migrate_new_notification_setting.rb @@ -1,6 +1,10 @@ # This migration will create one row of NotificationSetting for each Member row -# It can take long time on big instances. Its unclear yet if this migration can be done online. -# This comment should be updated by @dzaporozhets before 8.7 release. If not - please ask him to do so. +# It can take long time on big instances. +# +# This migration can be done online but with following effects: +# - during migration some users will receive notifications based on their global settings (project/group settings will be ignored) +# - its possible to get duplicate records for notification settings since we don't create uniq index yet +# class MigrateNewNotificationSetting < ActiveRecord::Migration def up timestamp = Time.now |