diff options
| author | Sean McGivern <sean@gitlab.com> | 2017-12-11 16:34:51 +0000 |
|---|---|---|
| committer | Sean McGivern <sean@gitlab.com> | 2017-12-11 16:34:51 +0000 |
| commit | 1ab33b15d1f1cc6ce69514e545da1348fd750771 (patch) | |
| tree | af4dab71355a5199facc7937aeb03f964e2f6d0c /db/migrate/20160913162434_remove_projects_pushes_since_gc.rb | |
| parent | 8ff63039f1ee5f6e31a8b910e323977e7de3c634 (diff) | |
| download | gitlab-ce-1ab33b15d1f1cc6ce69514e545da1348fd750771.tar.gz | |
Add cop for use of remove_columnadd-remove-column-cop
remove_column should only be used in the up (or change) step of a migration if
it's a post-deployment migration. Otherwise there will be downtime due to the
ActiveRecord column cache, which we can avoid by using the IgnorableColumn
concern in combination with a post-deployment migration.
Diffstat (limited to 'db/migrate/20160913162434_remove_projects_pushes_since_gc.rb')
| -rw-r--r-- | db/migrate/20160913162434_remove_projects_pushes_since_gc.rb | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/db/migrate/20160913162434_remove_projects_pushes_since_gc.rb b/db/migrate/20160913162434_remove_projects_pushes_since_gc.rb index df7d922b816..f32167037e0 100644 --- a/db/migrate/20160913162434_remove_projects_pushes_since_gc.rb +++ b/db/migrate/20160913162434_remove_projects_pushes_since_gc.rb @@ -1,3 +1,4 @@ +# rubocop:disable Migration/RemoveColumn # See http://doc.gitlab.com/ce/development/migration_style_guide.html # for more information on how to write migrations for GitLab. |