diff options
| author | Timothy Andrew <mail@timothyandrew.net> | 2016-09-20 15:06:54 +0530 |
|---|---|---|
| committer | Timothy Andrew <mail@timothyandrew.net> | 2016-09-20 16:05:25 +0530 |
| commit | 8957293d9bd0d711db3af26182205c2fe4125194 (patch) | |
| tree | dcdd25393e2d6248971fddbd6c9eac30fe27ff6e /db/migrate/20160915042921_create_merge_requests_closing_issues.rb | |
| parent | fa890604aaf15b9e4f0199e6a4cff24c29955a37 (diff) | |
| download | gitlab-ce-8957293d9bd0d711db3af26182205c2fe4125194.tar.gz | |
Implement review comments from @yorickpeterse
1. Change multiple updates to a single `update_all`
2. Use cascading deletes
3. Extract an average function for the database median.
4. Move database median to `lib/gitlab/database`
5. Use `delete_all` instead of `destroy_all`
6. Minor refactoring
Diffstat (limited to 'db/migrate/20160915042921_create_merge_requests_closing_issues.rb')
| -rw-r--r-- | db/migrate/20160915042921_create_merge_requests_closing_issues.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/db/migrate/20160915042921_create_merge_requests_closing_issues.rb b/db/migrate/20160915042921_create_merge_requests_closing_issues.rb index 02c28cbe0dd..049340f7085 100644 --- a/db/migrate/20160915042921_create_merge_requests_closing_issues.rb +++ b/db/migrate/20160915042921_create_merge_requests_closing_issues.rb @@ -25,8 +25,8 @@ class CreateMergeRequestsClosingIssues < ActiveRecord::Migration def change create_table :merge_requests_closing_issues do |t| - t.references :merge_request, foreign_key: true, index: true, null: false - t.references :issue, foreign_key: true, index: true, null: false + t.references :merge_request, foreign_key: true, index: true, dependent: :delete, null: false + t.references :issue, foreign_key: true, index: true, dependent: :delete, null: false t.timestamps null: false end |