diff options
| author | Stan Hu <stanhu@gmail.com> | 2019-06-19 11:06:47 -0700 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2019-06-19 13:30:41 -0700 |
| commit | 6c0bc9abdd2542cc0951bd34b150a5824b987636 (patch) | |
| tree | 45ebaac4246f5c5b95e1973035a49533d174c96b /db | |
| parent | 4a5bda06900b2b623f7f9fcdce6b36cdcf73bc51 (diff) | |
| download | gitlab-ce-6c0bc9abdd2542cc0951bd34b150a5824b987636.tar.gz | |
Remove import columns from projects tablesh-remove-import-columns-from-projects
In https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21497, we
migrated all project import data into a separate table,
`project_import_data`. In addition, we also added:
```
ignore_column :import_status, :import_jid, :import_error
```
In https://gitlab.com/gitlab-com/gl-infra/production/issues/908, we
observed some of these `import_error` columns consumed megabytes of
error backtraces and caused slow loading of projects whenever a `SELECT
* from projects` query loaded the row into memory.
Since we have long migrated away from these columns, we can now drop
these columns entirely.
Diffstat (limited to 'db')
| -rw-r--r-- | db/post_migrate/20190619175843_remove_import_columns_from_projects.rb | 14 | ||||
| -rw-r--r-- | db/schema.rb | 5 |
2 files changed, 15 insertions, 4 deletions
diff --git a/db/post_migrate/20190619175843_remove_import_columns_from_projects.rb b/db/post_migrate/20190619175843_remove_import_columns_from_projects.rb new file mode 100644 index 00000000000..85f776ac99c --- /dev/null +++ b/db/post_migrate/20190619175843_remove_import_columns_from_projects.rb @@ -0,0 +1,14 @@ +# frozen_string_literal: true + +class RemoveImportColumnsFromProjects < ActiveRecord::Migration[5.1] + include Gitlab::Database::MigrationHelpers + + # Set this constant to true if this migration requires downtime. + DOWNTIME = false + + def change + remove_column :projects, :import_status, :string + remove_column :projects, :import_jid, :string + remove_column :projects, :import_error, :text + end +end diff --git a/db/schema.rb b/db/schema.rb index 7a7319c132e..4e333633a8b 100644 --- a/db/schema.rb +++ b/db/schema.rb @@ -10,7 +10,7 @@ # # It's strongly recommended that you check this file into your version control system. -ActiveRecord::Schema.define(version: 20190613030606) do +ActiveRecord::Schema.define(version: 20190619175843) do # These are extensions that must be enabled in order to support this database enable_extension "plpgsql" @@ -2595,11 +2595,9 @@ ActiveRecord::Schema.define(version: 20190613030606) do t.integer "visibility_level", default: 0, null: false t.boolean "archived", default: false, null: false t.string "avatar" - t.string "import_status" t.integer "star_count", default: 0, null: false t.string "import_type" t.string "import_source" - t.text "import_error" t.boolean "shared_runners_enabled", default: true, null: false t.string "runners_token" t.string "build_coverage_regex" @@ -2621,7 +2619,6 @@ ActiveRecord::Schema.define(version: 20190613030606) do t.boolean "only_allow_merge_if_all_discussions_are_resolved" t.boolean "printing_merge_request_link_enabled", default: true, null: false t.integer "auto_cancel_pending_pipelines", default: 1, null: false - t.string "import_jid" t.integer "cached_markdown_version" t.text "delete_error" t.datetime "last_repository_updated_at" |