diff options
| author | GitLab Bot <gitlab-bot@gitlab.com> | 2020-04-03 09:09:31 +0000 |
|---|---|---|
| committer | GitLab Bot <gitlab-bot@gitlab.com> | 2020-04-03 09:09:31 +0000 |
| commit | 04baa85554ff13bdd4d6f4e6bb24119d17608fee (patch) | |
| tree | 7cb9c0977e09d97da340f48703d79b2dbd3579a0 /doc/development/database_review.md | |
| parent | 42f41de46525ce0065f02ee07c1a79f5669526a0 (diff) | |
| download | gitlab-ce-04baa85554ff13bdd4d6f4e6bb24119d17608fee.tar.gz | |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'doc/development/database_review.md')
| -rw-r--r-- | doc/development/database_review.md | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/doc/development/database_review.md b/doc/development/database_review.md index 650c6fc7936..d95fd7a38f6 100644 --- a/doc/development/database_review.md +++ b/doc/development/database_review.md @@ -80,6 +80,7 @@ the following preparations into account. - Add the output of the migration(s) to the MR description. - Add tests for the migration in `spec/migrations` if necessary. See [Testing Rails migrations at GitLab](testing_guide/testing_migrations_guide.md) for more details. - When [high-traffic](https://gitlab.com/gitlab-org/gitlab/-/blob/master/rubocop/migration_helpers.rb#L12) tables are involved in the migration, use the [`with_lock_retries`](migration_style_guide.md#retry-mechanism-when-acquiring-database-locks) helper method. Review the relevant [examples in our documentation](migration_style_guide.md#examples) for use cases and solutions. +- Ensure RuboCop checks are not disabled unless there's a valid reason to. #### Preparation when adding or modifying queries |