diff options
| author | GitLab Bot <gitlab-bot@gitlab.com> | 2020-04-02 18:08:11 +0000 |
|---|---|---|
| committer | GitLab Bot <gitlab-bot@gitlab.com> | 2020-04-02 18:08:11 +0000 |
| commit | 8a7efa45c38ed3200d173d2c3207a8154e583c16 (patch) | |
| tree | 1bb4d579b95c79aae4946a06fefa089e5549b722 /doc/development/database_review.md | |
| parent | 53b1f4eaa2a451aaba908a5fee7ce97a930021ac (diff) | |
| download | gitlab-ce-8a7efa45c38ed3200d173d2c3207a8154e583c16.tar.gz | |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'doc/development/database_review.md')
| -rw-r--r-- | doc/development/database_review.md | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/doc/development/database_review.md b/doc/development/database_review.md index 0fdf255e266..650c6fc7936 100644 --- a/doc/development/database_review.md +++ b/doc/development/database_review.md @@ -79,6 +79,7 @@ the following preparations into account. - Include either a rollback procedure or describe how to rollback changes. - Add the output of the migration(s) to the MR description. - Add tests for the migration in `spec/migrations` if necessary. See [Testing Rails migrations at GitLab](testing_guide/testing_migrations_guide.md) for more details. +- When [high-traffic](https://gitlab.com/gitlab-org/gitlab/-/blob/master/rubocop/migration_helpers.rb#L12) tables are involved in the migration, use the [`with_lock_retries`](migration_style_guide.md#retry-mechanism-when-acquiring-database-locks) helper method. Review the relevant [examples in our documentation](migration_style_guide.md#examples) for use cases and solutions. #### Preparation when adding or modifying queries |