summaryrefslogtreecommitdiff
path: root/doc/development/fe_guide
diff options
context:
space:
mode:
authorTim Zallmann <tzallmann@gitlab.com>2017-07-27 11:23:34 +0200
committerTim Zallmann <tzallmann@gitlab.com>2017-07-27 15:01:27 +0200
commit710d0435f7c54801ff9efafc14a46095f3c83244 (patch)
treee8fac60cd034531393c0655901f46c8e88dc81b7 /doc/development/fe_guide
parent14b9c83f41efeaa8f5468dcb81986d118e74d2d3 (diff)
downloadgitlab-ce-710d0435f7c54801ff9efafc14a46095f3c83244.tar.gz
Changed Images in Blob Viewer to image_tag35577-fix-image-blob-display-due-to-lazy-image-loading
Updated documentation about the lazy class
Diffstat (limited to 'doc/development/fe_guide')
-rw-r--r--doc/development/fe_guide/performance.md5
1 files changed, 3 insertions, 2 deletions
diff --git a/doc/development/fe_guide/performance.md b/doc/development/fe_guide/performance.md
index f25313d6cff..14ac1133cc0 100644
--- a/doc/development/fe_guide/performance.md
+++ b/doc/development/fe_guide/performance.md
@@ -29,11 +29,12 @@ To improve the time to first render we are using lazy loading for images. This w
the actual image source on the `data-src` attribute. After the HTML is rendered and JavaScript is loaded,
the value of `data-src` will be moved to `src` automatically if the image is in the current viewport.
-* Prepare images in HTML for lazy loading by renaming the `src` attribute to `data-src`
+* Prepare images in HTML for lazy loading by renaming the `src` attribute to `data-src` AND adding the class `lazy`
* If you are using the Rails `image_tag` helper, all images will be lazy-loaded by default unless `lazy: false` is provided.
If you are asynchronously adding content which contains lazy images then you need to call the function
-`gl.lazyLoader.searchLazyImages()` which will search for lazy images and load them if needed.
+`gl.lazyLoader.searchLazyImages()` which will search for lazy images and load them if needed.
+But in general it should be handled automatically through a `MutationObserver` in the lazy loading function.
## Reducing Asset Footprint