diff options
| author | Bryce Johnson <bryce@gitlab.com> | 2016-10-27 19:09:58 +0200 |
|---|---|---|
| committer | Bryce Johnson <bryce@gitlab.com> | 2016-10-31 11:39:52 +0100 |
| commit | 5fb226a934b07b214dcbd6711f1068866c0c1dae (patch) | |
| tree | 76cf76e0dd966b7e176c0be6f83eade4deeb189c /doc/development/gotchas.md | |
| parent | 696f09c7bf15c090c46a7d9abe14e0c769576db2 (diff) | |
| download | gitlab-ce-5fb226a934b07b214dcbd6711f1068866c0c1dae.tar.gz | |
Remove leftover references to coffeescript from comments and docs.decaffeinate-the-docs
Diffstat (limited to 'doc/development/gotchas.md')
| -rw-r--r-- | doc/development/gotchas.md | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/doc/development/gotchas.md b/doc/development/gotchas.md index 159d5ce286d..b25ce79e89f 100644 --- a/doc/development/gotchas.md +++ b/doc/development/gotchas.md @@ -41,9 +41,9 @@ Rubocop](https://gitlab.com/gitlab-org/gitlab-ce/blob/8-4-stable/.rubocop.yml#L9 [Exception]: http://stackoverflow.com/q/10048173/223897 -## Don't use inline CoffeeScript/JavaScript in views +## Don't use inline JavaScript in views -Using the inline `:coffee` or `:coffeescript` Haml filters comes with a +Using the inline `:javascript` Haml filters comes with a performance overhead. Using inline JavaScript is not a good way to structure your code and should be avoided. _**Note:** We've [removed these two filters](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/config/initializers/hamlit.rb) @@ -51,9 +51,7 @@ in an initializer._ ### Further reading -- Pull Request: [Replace CoffeeScript block into JavaScript in Views](https://git.io/vztMu) - Stack Overflow: [Why you should not write inline JavaScript](http://programmers.stackexchange.com/questions/86589/why-should-i-avoid-inline-scripting) -- Stack Overflow: [Performance implications of using :coffescript filter inside HAML templates?](http://stackoverflow.com/a/17571242/223897) ## ID-based CSS selectors need to be a bit more specific |