diff options
| author | Sean McGivern <sean@gitlab.com> | 2017-01-13 16:12:02 +0000 |
|---|---|---|
| committer | Sean McGivern <sean@gitlab.com> | 2017-01-13 16:12:02 +0000 |
| commit | e2585e642ac53802c6c5b4c2ee2ec3e6be584981 (patch) | |
| tree | e2278d9dfbb7173e46c20cbf80761b3840573812 /doc/development/merge_request_performance_guidelines.md | |
| parent | 4b43126d08972c201551fbd1fe42e85847d5e03f (diff) | |
| download | gitlab-ce-e2585e642ac53802c6c5b4c2ee2ec3e6be584981.tar.gz | |
Rename endboss -> maintainer, miniboss -> reviewerno-more-bosses
We want to describe these roles in a way that is more understandable to
people not familiar with GitLab.
Diffstat (limited to 'doc/development/merge_request_performance_guidelines.md')
| -rw-r--r-- | doc/development/merge_request_performance_guidelines.md | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/doc/development/merge_request_performance_guidelines.md b/doc/development/merge_request_performance_guidelines.md index 0363bf8c1d5..8232a0a113c 100644 --- a/doc/development/merge_request_performance_guidelines.md +++ b/doc/development/merge_request_performance_guidelines.md @@ -3,7 +3,7 @@ To ensure a merge request does not negatively impact performance of GitLab _every_ merge request **must** adhere to the guidelines outlined in this document. There are no exceptions to this rule unless specifically discussed -with and agreed upon by merge request endbosses and performance specialists. +with and agreed upon by backend maintainers and performance specialists. To measure the impact of a merge request you can use [Sherlock](profiling.md#sherlock). It's also highly recommended that you read @@ -40,9 +40,9 @@ section below for more information. about the impact. Sometimes it's hard to assess the impact of a merge request. In this case you -should ask one of the merge request (mini) endbosses to review your changes. You -can find a list of these endbosses at <https://about.gitlab.com/team/>. An -endboss in turn can request a performance specialist to review the changes. +should ask one of the merge request reviewers to review your changes. You can +find a list of these reviewers at <https://about.gitlab.com/team/>. A reviewer +in turn can request a performance specialist to review the changes. ## Query Counts |