summaryrefslogtreecommitdiff
path: root/doc/development/testing.md
diff options
context:
space:
mode:
authorLin Jen-Shin <godfat@godfat.org>2016-11-18 20:17:10 +0800
committerLin Jen-Shin <godfat@godfat.org>2016-11-18 20:17:10 +0800
commit9c4e0d64451bd76b829e1bb66afab892e19926da (patch)
tree7bcbfa45907119ab0039f696607fdf4e1557fb46 /doc/development/testing.md
parent688ff26df3f288e5cd50096a01014188a5e4011b (diff)
downloadgitlab-ce-9c4e0d64451bd76b829e1bb66afab892e19926da.tar.gz
Use `Gitlab.config.gitlab.host` over `'localhost'`fix-tests-for-different-host
This would fix long standing failures running tests on my development machine, which set `Gitlab.config.gitlab.host` to another host because it's not my local computer. Now I finally cannot withstand it and decided to fix them once and for all.
Diffstat (limited to 'doc/development/testing.md')
-rw-r--r--doc/development/testing.md1
1 files changed, 1 insertions, 0 deletions
diff --git a/doc/development/testing.md b/doc/development/testing.md
index 4dc535fb359..6106e47daa0 100644
--- a/doc/development/testing.md
+++ b/doc/development/testing.md
@@ -70,6 +70,7 @@ the command line via `bundle exec teaspoon`, or via a web browser at
- Try to match the ordering of tests to the ordering within the class.
- Try to follow the [Four-Phase Test][four-phase-test] pattern, using newlines
to separate phases.
+- Try to use `Gitlab.config.gitlab.host` rather than hard coding `'localhost'`
[four-phase-test]: https://robots.thoughtbot.com/four-phase-test