summaryrefslogtreecommitdiff
path: root/doc/development/testing_guide/end_to_end/style_guide.md
diff options
context:
space:
mode:
authorFabio Papa <fabtheman@gmail.com>2019-07-12 10:37:24 -0700
committerFabio Papa <fabtheman@gmail.com>2019-07-12 10:37:24 -0700
commit6c51aadf35c4e7899da99c85c3fc4c01484819f2 (patch)
treec683e3d7ebcf3e188f1dd85b8701ff972e7f8a3d /doc/development/testing_guide/end_to_end/style_guide.md
parent9b176c65159e4186f79eae2107af80e69132ba09 (diff)
parent6457d5edb7d66df5dd3d5ba1f1ea0c56a59287a8 (diff)
downloadgitlab-ce-6c51aadf35c4e7899da99c85c3fc4c01484819f2.tar.gz
Merge branch 'maintainers-can-create-subgroup' of https://gitlab.com/fapapa/gitlab-ce into maintainers-can-create-subgroup
Diffstat (limited to 'doc/development/testing_guide/end_to_end/style_guide.md')
-rw-r--r--doc/development/testing_guide/end_to_end/style_guide.md12
1 files changed, 6 insertions, 6 deletions
diff --git a/doc/development/testing_guide/end_to_end/style_guide.md b/doc/development/testing_guide/end_to_end/style_guide.md
index 0272e1810f2..52a8116e01c 100644
--- a/doc/development/testing_guide/end_to_end/style_guide.md
+++ b/doc/development/testing_guide/end_to_end/style_guide.md
@@ -63,17 +63,17 @@ We follow a simple formula roughly based on hungarian notation.
- `_checkbox`
- `_radio`
- `_content`
-
+
*Note: This list is a work in progress. This list will eventually be the end-all enumeration of all available types.
I.e., any element that does not end with something in this list is bad form.*
-
+
#### Examples
**Good**
```ruby
view '...' do
- element :edit_button
+ element :edit_button
element :notes_tab
element :squash_checkbox
element :username_field
@@ -84,15 +84,15 @@ end
**Bad**
```ruby
-view '...' do
+view '...' do
# `_confirmation` should be `_field`. what sort of confirmation? a checkbox confirmation? no real way to disambiguate.
# an appropriate replacement would be `element :password_confirmation_field`
element :password_confirmation
- # `clone_options` is too vague. If it's a dropdown menu, it should be `clone_dropdown`.
+ # `clone_options` is too vague. If it's a dropdown menu, it should be `clone_dropdown`.
# If it's a checkbox, it should be `clone_checkbox`
element :clone_options
-
+
# how is this url being displayed? is it a textbox? a simple span?
element :ssh_clone_url
end