summaryrefslogtreecommitdiff
path: root/doc/development/testing_guide
diff options
context:
space:
mode:
authorLin Jen-Shin <godfat@godfat.org>2019-08-20 11:35:21 +0000
committerLin Jen-Shin <godfat@godfat.org>2019-08-20 11:35:21 +0000
commit9e6a8bb93b6fbcbe5657079108332b99fc8749cc (patch)
tree07997c44727459b3c096e110cdd8937f3a363ea0 /doc/development/testing_guide
parentc44614dc47ae7d277531e4bdbc24b3a550dae1ad (diff)
parent3b7df66eef935046363c39d835b0a34d85b51584 (diff)
downloadgitlab-ce-9e6a8bb93b6fbcbe5657079108332b99fc8749cc.tar.gz
Merge branch 'docs-testing-n-1-request-sepcs' into 'master'
Docs: Require request specs when testing N+1 for controllers See merge request gitlab-org/gitlab-ce!31940
Diffstat (limited to 'doc/development/testing_guide')
-rw-r--r--doc/development/testing_guide/testing_levels.md2
1 files changed, 1 insertions, 1 deletions
diff --git a/doc/development/testing_guide/testing_levels.md b/doc/development/testing_guide/testing_levels.md
index 6c3a3171d39..0090c84cbf0 100644
--- a/doc/development/testing_guide/testing_levels.md
+++ b/doc/development/testing_guide/testing_levels.md
@@ -63,7 +63,7 @@ They're useful to test permissions, redirections, what view is rendered etc.
| Code path | Tests path | Testing engine | Notes |
| --------- | ---------- | -------------- | ----- |
-| `app/controllers/` | `spec/controllers/` | RSpec | |
+| `app/controllers/` | `spec/controllers/` | RSpec | For N+1 tests, use [request specs](../query_recorder.md#use-request-specs-instead-of-controller-specs) |
| `app/mailers/` | `spec/mailers/` | RSpec | |
| `lib/api/` | `spec/requests/api/` | RSpec | |
| `app/assets/javascripts/` | `spec/javascripts/`, `spec/frontend/` | Karma & Jest | More details in the [Frontend Testing guide](frontend_testing.md) section. |