diff options
| author | Nick Thomas <nick@gitlab.com> | 2018-05-10 12:31:36 +0000 |
|---|---|---|
| committer | Nick Thomas <nick@gitlab.com> | 2018-05-10 12:31:36 +0000 |
| commit | b7e9c968c24e5d380f5522067e46170a351c6b6c (patch) | |
| tree | d498cbfb40e87b1c93bc4abb7ab389671a6200a1 /doc/development | |
| parent | 3016cf26970353626db8437fb77a3ac22f83288c (diff) | |
| parent | 204af2e1019e661fddc451ad0cfb982453d4085b (diff) | |
| download | gitlab-ce-b7e9c968c24e5d380f5522067e46170a351c6b6c.tar.gz | |
Merge branch 'sh-reset-prometheus-metrics-tests' into 'master'
Support resetting of Prometheus metrics between test runs
Closes #39968
See merge request gitlab-org/gitlab-ce!18836
Diffstat (limited to 'doc/development')
| -rw-r--r-- | doc/development/testing_guide/best_practices.md | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/doc/development/testing_guide/best_practices.md b/doc/development/testing_guide/best_practices.md index 7b32e0a47e1..61fa5459b91 100644 --- a/doc/development/testing_guide/best_practices.md +++ b/doc/development/testing_guide/best_practices.md @@ -230,6 +230,11 @@ describe "#==" do end ``` +### Prometheus tests + +Prometheus metrics may be preserved from one test run to another. To ensure that metrics are +reset before each example, add the `:prometheus` tag to the Rspec test. + ### Matchers Custom matchers should be created to clarify the intent and/or hide the |