diff options
| author | Achilleas Pipinellis <axil@gitlab.com> | 2018-01-19 18:45:59 +0000 |
|---|---|---|
| committer | Achilleas Pipinellis <axil@gitlab.com> | 2018-01-19 18:45:59 +0000 |
| commit | e3716e0f33125c46441aa230a7f55025cf2737c8 (patch) | |
| tree | ce894f48a7d9199085b5320c1f8218b7fbbfa8f4 /doc/development | |
| parent | 9fb5bd416dbb9e7890a2befaa4145c3c8dde2431 (diff) | |
| parent | 408e3cc1c43e7e09c96c40cb5e0c048b6cb8d154 (diff) | |
| download | gitlab-ce-e3716e0f33125c46441aa230a7f55025cf2737c8.tar.gz | |
Merge branch 'patch-28' into 'master'
Update best_practices.md
See merge request gitlab-org/gitlab-ce!16579
Diffstat (limited to 'doc/development')
| -rw-r--r-- | doc/development/testing_guide/best_practices.md | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/doc/development/testing_guide/best_practices.md b/doc/development/testing_guide/best_practices.md index edb8f372ea3..f5e8b4f146f 100644 --- a/doc/development/testing_guide/best_practices.md +++ b/doc/development/testing_guide/best_practices.md @@ -26,7 +26,6 @@ Here are some things to keep in mind regarding test performance: - Use `.method` to describe class methods and `#method` to describe instance methods. - Use `context` to test branching logic. -- Don't assert against the absolute value of a sequence-generated attribute (see [Gotchas](../gotchas.md#dont-assert-against-the-absolute-value-of-a-sequence-generated-attribute)). - Try to match the ordering of tests to the ordering within the class. - Try to follow the [Four-Phase Test][four-phase-test] pattern, using newlines to separate phases. |