diff options
| author | Rémy Coutable <remy@rymai.me> | 2017-05-04 09:02:39 +0200 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2017-05-04 09:02:39 +0200 |
| commit | 38c29f8775e393164e04fb1faf6c6b05fd105df6 (patch) | |
| tree | 565a54ed85899b4bb8132a7c97e9fb17b410b862 /doc/development | |
| parent | cb87903c6eec14e42fc23e0488f6c0769ba627d9 (diff) | |
| download | gitlab-ce-38c29f8775e393164e04fb1faf6c6b05fd105df6.tar.gz | |
Improving copy of CONTRIBUTING.md, PROCESS.md, and code_review.mddocs/30141-improve-contributing-guide
Signed-off-by: Rémy Coutable <remy@rymai.me>
Diffstat (limited to 'doc/development')
| -rw-r--r-- | doc/development/code_review.md | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index 138817f5440..be3dd1e2cc6 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -95,8 +95,6 @@ experience, refactors the existing code). Then: "LGTM :thumbsup:", or "Just a couple things to address." - Assign the merge request to the author if changes are required following your review. -- You should try to resolve merge conflicts yourself, using the [merge conflict - resolution][conflict-resolution] tool. - Set the milestone before merging a merge request. - Avoid accepting a merge request before the job succeeds. Of course, "Merge When Pipeline Succeeds" (MWPS) is fine. @@ -105,7 +103,6 @@ experience, refactors the existing code). Then: - Consider using the [Squash and merge][squash-and-merge] feature when the merge request has a lot of commits. -[conflict-resolution]: https://docs.gitlab.com/ce/user/project/merge_requests/resolve_conflicts.html#merge-conflict-resolution [squash-and-merge]: https://docs.gitlab.com/ee/user/project/merge_requests/squash_and_merge.html#squash-and-merge ### The right balance |