diff options
| author | GitLab Bot <gitlab-bot@gitlab.com> | 2020-03-31 21:08:05 +0000 |
|---|---|---|
| committer | GitLab Bot <gitlab-bot@gitlab.com> | 2020-03-31 21:08:05 +0000 |
| commit | abae8f34f377519946a91101ef7abf504454531c (patch) | |
| tree | 359fab0082860b6850d4a0a492b8f12eb3d4eb0b /doc/development | |
| parent | 580622bdb3c762a8e89facd8a3946881ee480442 (diff) | |
| download | gitlab-ce-abae8f34f377519946a91101ef7abf504454531c.tar.gz | |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'doc/development')
| -rw-r--r-- | doc/development/testing_guide/best_practices.md | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/doc/development/testing_guide/best_practices.md b/doc/development/testing_guide/best_practices.md index 108003b2d76..31a449dbbb2 100644 --- a/doc/development/testing_guide/best_practices.md +++ b/doc/development/testing_guide/best_practices.md @@ -543,7 +543,8 @@ expect(metrics.merged_at).to be_like_time(time) #### `have_gitlab_http_status` -Prefer `have_gitlab_http_status` over `have_http_status` because the former +Prefer `have_gitlab_http_status` over `have_http_status` and +`expect(response.status).to` because the former could also show the response body whenever the status mismatched. This would be very useful whenever some tests start breaking and we would love to know why without editing the source and rerun the tests. |