Add latest changes from gitlab-org/gitlab@master

5 files changed, 15 insertions, 27 deletions

diff --git a/doc/development/i18n/externalization.md b/doc/development/i18n/externalization.md
index 5c6e31d0a37..a550d977916 100644
--- a/doc/development/i18n/externalization.md
+++ b/doc/development/i18n/externalization.md
@@ -292,9 +292,7 @@ const dateFormat = createDateTimeFormat({ year: 'numeric', month: 'long', day: '
 console.log(dateFormat.format(new Date('2063-04-05'))) // April 5, 2063
 ```
 
-This makes use of [`Intl.DateTimeFormat`].
-
-[`Intl.DateTimeFormat`]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/DateTimeFormat
+This makes use of [`Intl.DateTimeFormat`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/DateTimeFormat).
 
 - In Ruby/HAML, we have two ways of adding format to dates and times:
 
@@ -404,9 +402,7 @@ This also applies when using links in between translated sentences, otherwise th
 The reasoning behind this is that in some languages words change depending on context. For example in Japanese は is added to the subject of a sentence and を to the object. This is impossible to translate correctly if we extract individual words from the sentence.
 
 When in doubt, try to follow the best practices described in this [Mozilla
-Developer documentation][mdn].
-
-[mdn]: https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Splitting
+Developer documentation](https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Splitting).
 
 ##### Vue components interpolation
 
diff --git a/doc/development/i18n/proofreader.md b/doc/development/i18n/proofreader.md
index 5535011d8c1..0e631a41de8 100644
--- a/doc/development/i18n/proofreader.md
+++ b/doc/development/i18n/proofreader.md
@@ -121,7 +121,7 @@ are very appreciative of the work done by translators and proofreaders!
 1. Request proofreader permissions by opening a merge request to add yourself
    to the list of proofreaders.
 
-   Open the [proofreader.md source file][proofreader-src] and click **Edit**.
+   Open the [proofreader.md source file](https://gitlab.com/gitlab-org/gitlab/blob/master/doc/development/i18n/proofreader.md) and click **Edit**.
 
    Add your language in alphabetical order, and add yourself to the list
    including:
@@ -138,5 +138,3 @@ are very appreciative of the work done by translators and proofreaders!
    the language or current proofreaders.
    - When a request is made for the first proofreader for a language and there are no [GitLab team members](https://about.gitlab.com/company/team/)
    or [Core team members](https://about.gitlab.com/community/core-team/) who speak the language, we will request links to previous translation work in other communities or projects.
-
-[proofreader-src]: https://gitlab.com/gitlab-org/gitlab/blob/master/doc/development/i18n/proofreader.md
diff --git a/doc/development/i18n/translation.md b/doc/development/i18n/translation.md
index 50a417e9996..683dae6ce3d 100644
--- a/doc/development/i18n/translation.md
+++ b/doc/development/i18n/translation.md
@@ -69,7 +69,7 @@ determining a suitable level of formality.
 
 ### Inclusive language
 
-[Diversity] is one of GitLab's values.
+[Diversity](https://about.gitlab.com/handbook/values/#diversity) is one of GitLab's values.
 We ask you to avoid translations which exclude people based on their gender or
 ethnicity.
 In languages which distinguish between a male and female form, use both or
@@ -78,8 +78,6 @@ choose a neutral formulation.
 For example in German, the word "user" can be translated into "Benutzer" (male) or "Benutzerin" (female).
 Therefore "create a new user" would translate into "Benutzer(in) anlegen".
 
-[Diversity]: https://about.gitlab.com/handbook/values/#diversity
-
 ### Updating the glossary
 
 To propose additions to the glossary please
diff --git a/doc/development/lfs.md b/doc/development/lfs.md
index 63271531960..e64bc0f7d3a 100644
--- a/doc/development/lfs.md
+++ b/doc/development/lfs.md
@@ -2,10 +2,11 @@
 
 ## Deep Dive
 
-In April 2019, Francisco Javier López hosted a [Deep Dive] on GitLab's [Git LFS] implementation to share his domain specific knowledge with anyone who may work in this part of the code base in the future. You can find the [recording on YouTube], and the slides on [Google Slides] and in [PDF]. Everything covered in this deep dive was accurate as of GitLab 11.10, and while specific details may have changed since then, it should still serve as a good introduction.
-
-[Deep Dive]: https://gitlab.com/gitlab-org/create-stage/issues/1
-[Git LFS]: ../topics/git/lfs/index.md
-[recording on YouTube]: https://www.youtube.com/watch?v=Yyxwcksr0Qc
-[Google Slides]: https://docs.google.com/presentation/d/1E-aw6-z0rYd0346YhIWE7E9A65zISL9iIMAOq2zaw9E/edit
-[PDF]: https://gitlab.com/gitlab-org/create-stage/uploads/07a89257a140db067bdfb484aecd35e1/Git_LFS_Deep_Dive__Create_.pdf
+In April 2019, Francisco Javier López hosted a [Deep Dive](https://gitlab.com/gitlab-org/create-stage/issues/1)
+on GitLab's [Git LFS](../topics/git/lfs/index.md) implementation to share his domain
+specific knowledge with anyone who may work in this part of the code base in the future.
+You can find the [recording on YouTube](https://www.youtube.com/watch?v=Yyxwcksr0Qc),
+and the slides on [Google Slides](https://docs.google.com/presentation/d/1E-aw6-z0rYd0346YhIWE7E9A65zISL9iIMAOq2zaw9E/edit)
+and in [PDF](https://gitlab.com/gitlab-org/create-stage/uploads/07a89257a140db067bdfb484aecd35e1/Git_LFS_Deep_Dive__Create_.pdf).
+Everything covered in this deep dive was accurate as of GitLab 11.10, and while specific
+details may have changed since then, it should still serve as a good introduction.
diff --git a/doc/development/testing_guide/ci.md b/doc/development/testing_guide/ci.md
index 5bdd0a69d7f..6917639454c 100644
--- a/doc/development/testing_guide/ci.md
+++ b/doc/development/testing_guide/ci.md
@@ -25,23 +25,18 @@ After that, the next pipeline will use the up-to-date `knapsack/report-master.js
 
 ## Monitoring
 
-The GitLab test suite is [monitored] for the `master` branch, and any branch
+The GitLab test suite is [monitored](../performance.md#rspec-profiling) for the `master` branch, and any branch
 that includes `rspec-profile` in their name.
 
-A [public dashboard] is available for everyone to see. Feel free to look at the
+A [public dashboard](https://redash.gitlab.com/public/dashboards/l1WhHXaxrCWM5Ai9D7YDqHKehq6OU3bx5gssaiWe?org_slug=default) is available for everyone to see. Feel free to look at the
 slowest test files and try to improve them.
 
-[monitored]: ../performance.md#rspec-profiling
-[public dashboard]: https://redash.gitlab.com/public/dashboards/l1WhHXaxrCWM5Ai9D7YDqHKehq6OU3bx5gssaiWe?org_slug=default
-
 ## CI setup
 
 - Rails logging to `log/test.log` is disabled by default in CI [for
-  performance reasons][logging]. To override this setting, provide the
+  performance reasons](https://jtway.co/speed-up-your-rails-test-suite-by-6-in-1-line-13fedb869ec4). To override this setting, provide the
   `RAILS_ENABLE_TEST_LOG` environment variable.
 
-[logging]: https://jtway.co/speed-up-your-rails-test-suite-by-6-in-1-line-13fedb869ec4
-
 ---
 
 [Return to Testing documentation](index.md)