summaryrefslogtreecommitdiff
path: root/doc/development
diff options
context:
space:
mode:
authorRobert Speicher <rspeicher@gmail.com>2016-05-05 17:22:18 -0400
committerRobert Speicher <rspeicher@gmail.com>2016-05-05 17:22:18 -0400
commitdf9a7c6b4acf0a662366b2e31d897cda370c2216 (patch)
treeacc7e967b16976484e3102c921a0142180fcce69 /doc/development
parent56c49f4fb50b3b1fe170c93d8a0f67ec4e32888f (diff)
downloadgitlab-ce-df9a7c6b4acf0a662366b2e31d897cda370c2216.tar.gz
Add a note to testing docs about the `:each` argument to RSpec hooks
[ci skip]
Diffstat (limited to 'doc/development')
-rw-r--r--doc/development/testing.md1
1 files changed, 1 insertions, 0 deletions
diff --git a/doc/development/testing.md b/doc/development/testing.md
index 672e3fb4649..33eed29ba5c 100644
--- a/doc/development/testing.md
+++ b/doc/development/testing.md
@@ -64,6 +64,7 @@ the command line via `bundle exec teaspoon`, or via a web browser at
methods.
- Use `context` to test branching logic.
- Don't `describe` symbols (see [Gotchas](gotchas.md#dont-describe-symbols)).
+- Don't supply the `:each` argument to hooks since it's the default.
- Prefer `not_to` to `to_not`.
- Try to match the ordering of tests to the ordering within the class.
- Try to follow the [Four-Phase Test][four-phase-test] pattern, using newlines