summaryrefslogtreecommitdiff
path: root/doc/development
diff options
context:
space:
mode:
authorClement Ho <ClemMakesApps@gmail.com>2017-07-31 14:00:52 -0500
committerClement Ho <ClemMakesApps@gmail.com>2017-07-31 14:00:52 -0500
commitfac3c91728457a4ee57dcf789aac27462e295e43 (patch)
tree5e8d8fea75987aec495a4b6365caac9d61ac3ee3 /doc/development
parentda967803cce971b184873dbe5d65d07215de0b0a (diff)
downloadgitlab-ce-fac3c91728457a4ee57dcf789aac27462e295e43.tar.gz
Add specific code review guidelinesadd-specific-review-examples
Diffstat (limited to 'doc/development')
-rw-r--r--doc/development/code_review.md8
1 files changed, 8 insertions, 0 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md
index e3f37616757..23313446d34 100644
--- a/doc/development/code_review.md
+++ b/doc/development/code_review.md
@@ -9,8 +9,16 @@ There are a few rules to get your merge request accepted:
**approved by a [backend maintainer][projects]**.
1. If your merge request includes only frontend changes [^1], it must be
**approved by a [frontend maintainer][projects]**.
+ 1. If your merge request includes UX changes [^1], it must
+ be **approved by a [UX team member][team]**.
+ 1. If your merge request includes adding a new JavaScript library [^1], it must be
+ **approved by a [frontend lead][team]**.
1. If your merge request includes frontend and backend changes [^1], it must
be **approved by a [frontend and a backend maintainer][projects]**.
+ 1. If your merge request includes UX and frontend changes [^1], it must
+ be **approved by a [UX team member and a frontend maintainer][team]**.
+ 1. If your merge request includes UX, frontend and backend changes [^1], it must
+ be **approved by a [UX team member, a frontend and a backend maintainer][team]**.
1. To lower the amount of merge requests maintainers need to review, you can
ask or assign any [reviewers][projects] for a first review.
1. If you need some guidance (e.g. it's your first merge request), feel free