summaryrefslogtreecommitdiff
path: root/doc/integration
diff options
context:
space:
mode:
authorRémy Coutable <remy@rymai.me>2016-07-08 15:50:02 +0000
committerRémy Coutable <remy@rymai.me>2016-07-08 15:50:02 +0000
commitfa82fd12835b2f4554df31fcdaa33f66e6f74907 (patch)
treeecb1ab4d2f9bf48d6401e542346302c44a4f3ee8 /doc/integration
parentb5a16faa93c40816eab7f7a13534d38524e26e22 (diff)
parente921fc90b830002f66e6de24165559154a08da6f (diff)
downloadgitlab-ce-fa82fd12835b2f4554df31fcdaa33f66e6f74907.tar.gz
Merge branch 'clarify-github-integration-docs' into 'master'
Fix documentation for Github integration authorization callback url. There are two callbacks that could be used with Github integration: * /import/github/callback (used by project import) * /users/auth/github/callback (used by OmniAuth) Github's documentation suggests that authorization callback url should be set to the longest common path. https://developer.github.com/v3/oauth/#redirect-urls Configuring according to the previous documentation resulted in a redirect_uri_mismatch error from Github when logging in via OmniAuth. See merge request !4111
Diffstat (limited to 'doc/integration')
-rw-r--r--doc/integration/github.md2
1 files changed, 1 insertions, 1 deletions
diff --git a/doc/integration/github.md b/doc/integration/github.md
index e7497e475c9..340c8a55fb3 100644
--- a/doc/integration/github.md
+++ b/doc/integration/github.md
@@ -19,7 +19,7 @@ GitHub will generate an application ID and secret key for you to use.
- Application name: This can be anything. Consider something like "\<Organization\>'s GitLab" or "\<Your Name\>'s GitLab" or something else descriptive.
- Homepage URL: The URL to your GitLab installation. 'https://gitlab.company.com'
- Application description: Fill this in if you wish.
- - Default authorization callback URL is '${YOUR_DOMAIN}/import/github/callback'
+ - Authorization callback URL is 'http(s)://${YOUR_DOMAIN}'
1. Select "Register application".
1. You should now see a Client ID and Client Secret near the top right of the page (see screenshot).