summaryrefslogtreecommitdiff
path: root/doc/integration
diff options
context:
space:
mode:
authorDennis Jekubczyk <dennis.jekubczyk@gmail.com>2019-02-13 12:49:38 +0000
committerDennis Jekubczyk <dennis.jekubczyk@gmail.com>2019-02-13 12:49:38 +0000
commitd219fbb95ffc1e15a9d03bd2fd85602db47f76ac (patch)
tree3cb557178b135f2469662264a414cf6cb529ce65 /doc/integration
parentc5e57aa89566a0a1889763d7134860c3f2a3e03a (diff)
downloadgitlab-ce-d219fbb95ffc1e15a9d03bd2fd85602db47f76ac.tar.gz
Fix callback url
Diffstat (limited to 'doc/integration')
-rw-r--r--doc/integration/github.md4
1 files changed, 2 insertions, 2 deletions
diff --git a/doc/integration/github.md b/doc/integration/github.md
index eca9aa16499..9bb3579dd84 100644
--- a/doc/integration/github.md
+++ b/doc/integration/github.md
@@ -21,10 +21,10 @@ To get the credentials (a pair of Client ID and Client Secret), you must registe
- Application name: This can be anything. Consider something like `<Organization>'s GitLab` or `<Your Name>'s GitLab` or something else descriptive.
- Homepage URL: the URL to your GitLab installation. e.g., `https://gitlab.company.com`
- Application description: Fill this in if you wish.
- - Authorization callback URL: `http(s)://${YOUR_DOMAIN}/users/auth`. Please make sure the port is included if your GitLab instance is not configured on default port.
+ - Authorization callback URL: `http(s)://${YOUR_DOMAIN}/users/auth/github/callback`. Please make sure the port is included if your GitLab instance is not configured on default port.
![Register OAuth App](img/github_register_app.png)
- NOTE: Be sure to append `/users/auth` to the end of the callback URL
+ NOTE: Be sure to append `/users/auth/github/callback` to the end of the callback URL
to prevent a [OAuth2 convert
redirect](http://tetraph.com/covert_redirect/) vulnerability.