summaryrefslogtreecommitdiff
path: root/doc/web_hooks
diff options
context:
space:
mode:
authorJacob Vosmaer <contact@jacobvosmaer.nl>2016-05-03 13:03:10 +0200
committerJacob Vosmaer <contact@jacobvosmaer.nl>2016-05-03 13:03:10 +0200
commitf4e0c56279007fd6cec3d8e6bd684f0483b0e0ff (patch)
treea3dbc884f0acbccb5e8d483d1aa3457e4063ead0 /doc/web_hooks
parentf0c4f727359a5848d12e2097bad6a6a3190943ef (diff)
downloadgitlab-ce-f4e0c56279007fd6cec3d8e6bd684f0483b0e0ff.tar.gz
Improve documentation and web test for web hooks
I wanted to share what I learned trying to debug web hooks using netcat.
Diffstat (limited to 'doc/web_hooks')
-rw-r--r--doc/web_hooks/web_hooks.md13
1 files changed, 13 insertions, 0 deletions
diff --git a/doc/web_hooks/web_hooks.md b/doc/web_hooks/web_hooks.md
index c1c51302e79..6ffdb18339e 100644
--- a/doc/web_hooks/web_hooks.md
+++ b/doc/web_hooks/web_hooks.md
@@ -13,6 +13,19 @@ You can configure webhooks to listen for specific events like pushes, issues or
Webhooks can be used to update an external issue tracker, trigger CI builds, update a backup mirror, or even deploy to your production server.
+## Webhook endpoint tips
+
+If you are writing your own endpoint (web server) that will receive
+GitLab web hooks keep in mind the following things:
+
+- Your endpoint should send its HTTP response as fast as possible. If
+ you wait too long, GitLab may decide the hook failed and retry it.
+- Your endpoint should ALWAYS return a valid HTTP response. If you do
+ not do this then GitLab will think the hook failed and retry it.
+ Most HTTP libraries take care of this for you automatically but if
+ you are writing a low-level hook this is important to remember.
+- GitLab ignores the HTTP status code returned by your endpoint.
+
## SSL Verification
By default, the SSL certificate of the webhook endpoint is verified based on