summaryrefslogtreecommitdiff
path: root/doc
diff options
context:
space:
mode:
authorYorick Peterse <yorickpeterse@gmail.com>2018-09-18 16:14:38 +0200
committerYorick Peterse <yorickpeterse@gmail.com>2018-09-18 16:22:29 +0200
commit4ef1dd09ddc5701de5ed72887d9e682f4650e732 (patch)
treecd38bacbf1977d56bc56c855fb3163398b7436c2 /doc
parenta2a00a5e6d1ba3d2ebfafcff57e211cb1b65c00a (diff)
downloadgitlab-ce-4ef1dd09ddc5701de5ed72887d9e682f4650e732.tar.gz
Improve Emoji detection in commit messages
This changes our Danger integration so that it is smarter about detecting GitLab emoji in commit messages. This is done using a two step process: 1. We use the old regular expression to determine if a commit message _might_ include an emoji. 2. If this regular expression matches, we then check for all existing emoji names in the commit message. This might be a wee bit expensive, but because we couple it with the previous step it should be rarely executed. This ensures we don't trigger an error when a commit message includes text such as `:foo:bar:`, which is not a valid Emoji. Fixes https://gitlab.com/gitlab-org/release/framework/issues/15
Diffstat (limited to 'doc')
0 files changed, 0 insertions, 0 deletions