diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2019-12-13 03:07:50 +0000 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2019-12-13 03:07:50 +0000 |
commit | 38bab6e1581d30c0e9d312474fd796404cc7b484 (patch) | |
tree | e4e6b11e2788cae577ecb1efa5195f9bc77b83f2 /doc | |
parent | 47b8f79a0896f406008d5a7eda2781f8da301e91 (diff) | |
download | gitlab-ce-38bab6e1581d30c0e9d312474fd796404cc7b484.tar.gz |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'doc')
-rw-r--r-- | doc/development/dangerbot.md | 6 | ||||
-rw-r--r-- | doc/user/project/clusters/serverless/index.md | 4 |
2 files changed, 8 insertions, 2 deletions
diff --git a/doc/development/dangerbot.md b/doc/development/dangerbot.md index 0b2e2b43512..40eb4294617 100644 --- a/doc/development/dangerbot.md +++ b/doc/development/dangerbot.md @@ -95,6 +95,12 @@ through in CI. However, you can speed these cycles up somewhat by emptying the `.gitlab/ci/rails.gitlab-ci.yml` file in your merge request. Just don't forget to revert the change before merging! +To enable the Dangerfile on another existing GitLab project, run the following extra steps, based on [this procedure](https://danger.systems/guides/getting_started.html#creating-a-bot-account-for-danger-to-use): + +1. Add `@gitlab-bot` to the project as a `reporter`. +1. Add the `@gitlab-bot`'s `GITLAB_API_PRIVATE_TOKEN` value as a value for a new CI/CD + variable named `DANGER_GITLAB_API_TOKEN`. + You should add the `~Danger bot` label to the merge request before sending it for review. diff --git a/doc/user/project/clusters/serverless/index.md b/doc/user/project/clusters/serverless/index.md index 55bce10a49d..81aff05a32a 100644 --- a/doc/user/project/clusters/serverless/index.md +++ b/doc/user/project/clusters/serverless/index.md @@ -13,7 +13,7 @@ GitLab supports several ways deploy Serverless applications in both Kubernetes E Currently we support: -- [Knative](#knative): Build Knative applications with Knative and `gitlabktl` on GKE. +- [Knative](#knative): Build Knative applications with Knative and `gitlabktl` on GKE and EKS. - [AWS Lambda](aws.md): Create serverless applications via the Serverless Framework and GitLab CI. ## Knative @@ -89,7 +89,7 @@ The minimum recommended cluster size to run Knative is 3-nodes, 6 vCPUs, and 22. for other platforms [Install kubectl](https://kubernetes.io/docs/tasks/tools/install-kubectl/). 1. The Ingress is now available at this address and will route incoming requests to the proper service based on the DNS - name in the request. To support this, a wildcard DNS A record should be created for the desired domain name. For example, + name in the request. To support this, a wildcard DNS record should be created for the desired domain name. For example, if your Knative base domain is `knative.info` then you need to create an A record or CNAME record with domain `*.knative.info` pointing the ip address or hostname of the Ingress. |