diff options
| author | Eric Eastwood <contact@ericeastwood.com> | 2017-06-06 15:46:31 -0500 |
|---|---|---|
| committer | Eric Eastwood <contact@ericeastwood.com> | 2017-06-23 02:12:45 -0500 |
| commit | 6cb575d612cd2470ee4224159fa16458f5426f73 (patch) | |
| tree | da44a611e31d2f694ed8f3e55b1e45aac3703cae /doc | |
| parent | bf0b3d835211077cb10ee3aec9ee6e0bca2304b6 (diff) | |
| download | gitlab-ce-6cb575d612cd2470ee4224159fa16458f5426f73.tar.gz | |
Add support for multiple tooltips in the same Vue component
Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/33223
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/development/fe_guide/style_guide_js.md | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/doc/development/fe_guide/style_guide_js.md b/doc/development/fe_guide/style_guide_js.md index d2d89517241..ae844fa1051 100644 --- a/doc/development/fe_guide/style_guide_js.md +++ b/doc/development/fe_guide/style_guide_js.md @@ -463,20 +463,24 @@ A forEach will cause side effects, it will be mutating the array being iterated. 1. `destroyed` #### Vue and Boostrap -1. Tooltips: Do not rely on `has-tooltip` class name for vue components +1. Tooltips: Do not rely on `has-tooltip` class name for Vue components ``` javascript // bad - <span class="has-tooltip"> + <span + class="has-tooltip" + title="Some tooltip text"> Text </span> // good - <span data-toggle="tooltip"> + <span + v-tooltip + title="Some tooltip text"> Text </span> ``` -1. Tooltips: When using a tooltip, include the tooltip mixin +1. Tooltips: When using a tooltip, include the tooltip directive, `./app/assets/javascripts/vue_shared/directives/tooltip.js` 1. Don't change `data-original-title`. ```javascript |