diff options
| author | Zeger-Jan van de Weg <git@zjvandeweg.nl> | 2019-02-18 07:14:16 +0000 |
|---|---|---|
| committer | Zeger-Jan van de Weg <git@zjvandeweg.nl> | 2019-02-18 07:14:16 +0000 |
| commit | 633cb37e288163e1cca7c5bc2721105dcfea48a9 (patch) | |
| tree | df8f55c04b803efc88fb17b19a37aead5d2d3b47 /doc | |
| parent | 341556816c37b996dac1f7b343224e6fb4a6b8a9 (diff) | |
| download | gitlab-ce-633cb37e288163e1cca7c5bc2721105dcfea48a9.tar.gz | |
Improve language
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/development/code_review.md | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index f45de25aee5..e38aad55afa 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -134,10 +134,11 @@ as the maintainer to ultimately approve and merge it. Try to review in a timely manner; doing so allows everyone involved in the merge request to iterate faster as the context is fresh in memory. Further, this -improves contributors' experiences significantly. Provided full availability; -reviewing within two work days should be the aim. If you don't think you'll be -able to review a merge request within that time, let the author know as soon as -possible. +improves contributors' experiences significantly. Reviewers should aim to review +within two working days from the date they were assigned the merge request. If +you don't think you'll be able to review a merge request within that time, let +the author know as soon as possible. When the author of the merge request has not +heard anything after two days, a new reviewer should be assigned. Maintainers should check before merging if the merge request is approved by the required approvers. |