diff options
author | Michael Kozono <mkozono@gmail.com> | 2019-08-30 21:59:31 +0000 |
---|---|---|
committer | Michael Kozono <mkozono@gmail.com> | 2019-08-30 21:59:31 +0000 |
commit | 88c6423e4a45103cc480467bc8f412a48e1e0b55 (patch) | |
tree | c16f8134756de3acb3106fd9092ec0f73c8dc3b3 /doc | |
parent | 1495a84cb7620f4d3d92b17146e760a523b1ede1 (diff) | |
parent | d93b985df07ccf07541efef709edb8467e0f2955 (diff) | |
download | gitlab-ce-88c6423e4a45103cc480467bc8f412a48e1e0b55.tar.gz |
Merge branch 'remove-ignorable-column-concern' into 'master'
Remove dependency on IgnorableColumn concern
Closes #66746
See merge request gitlab-org/gitlab-ce!32427
Diffstat (limited to 'doc')
-rw-r--r-- | doc/development/what_requires_downtime.md | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/doc/development/what_requires_downtime.md b/doc/development/what_requires_downtime.md index 944bf5900c5..f4cee410066 100644 --- a/doc/development/what_requires_downtime.md +++ b/doc/development/what_requires_downtime.md @@ -45,15 +45,12 @@ rule. The first step is to ignore the column in the application code. This is necessary because Rails caches the columns and re-uses this cache in various -places. This can be done by including the `IgnorableColumn` module into the -model, followed by defining the columns to ignore. For example, to ignore +places. This can be done by defining the columns to ignore. For example, to ignore `updated_at` in the User model you'd use the following: ```ruby -class User < ActiveRecord::Base - include IgnorableColumn - - ignore_column :updated_at +class User < ApplicationRecord + self.ignored_columns += %i[updated_at] end ``` @@ -64,8 +61,7 @@ column. Both these changes should be submitted in the same merge request. Once the changes from step 1 have been released & deployed you can set up a separate merge request that removes the ignore rule. This merge request can -simply remove the `ignore_column` line, and the `include IgnorableColumn` line -if no other `ignore_column` calls remain. +simply remove the `self.ignored_columns` line. ## Renaming Columns |