summaryrefslogtreecommitdiff
path: root/doc
diff options
context:
space:
mode:
authorYorick Peterse <yorickpeterse@gmail.com>2018-02-13 16:40:23 +0100
committerYorick Peterse <yorickpeterse@gmail.com>2018-02-13 17:26:59 +0100
commite3bd674e81d565ef3bd399a70b3039316b518693 (patch)
treeb7b448145266a90d59a6b08266e398e4dcd8de0c /doc
parent4e846c735f8ec7e24e61454b0506b839a8f0ff3f (diff)
downloadgitlab-ce-e3bd674e81d565ef3bd399a70b3039316b518693.tar.gz
Remove Sentry reporting for query limiting
Using Sentry, while useful, poses two problems you have to choose from: 1. All errors are reported separately, making it easy to create issues but also making it next to impossible to see other errors (due to the sheer volume of threshold errors). 2. Errors can be grouped or merged together, reducing the noise. This however also means it's (as far as I can tell) much harder to automatically create GitLab issues from Sentry for the offending controllers. Since both solutions are terrible I decided to go with a third option: not using Sentry for this at all. Instead we'll investigate using Prometheus alerts and Grafana dashboards for this, which has the added benefit of being able to more accurately measure the behaviour over time. Note that throwing errors in test environments is still enabled, and whitelisting is still necessary to prevent that from happening (and that in turn still requires that developers create issues).
Diffstat (limited to 'doc')
-rw-r--r--doc/development/query_count_limits.md5
1 files changed, 2 insertions, 3 deletions
diff --git a/doc/development/query_count_limits.md b/doc/development/query_count_limits.md
index ebb6e0c2dac..310e3faf61b 100644
--- a/doc/development/query_count_limits.md
+++ b/doc/development/query_count_limits.md
@@ -1,8 +1,7 @@
# Query Count Limits
-Each controller or API endpoint is allowed to execute up to 100 SQL queries. In
-a production environment we'll only log an error in case this threshold is
-exceeded, but in a test environment we'll raise an error instead.
+Each controller or API endpoint is allowed to execute up to 100 SQL queries and
+in test environments we'll raise an error when this threshold is exceeded.
## Solving Failing Tests