diff options
| author | Ramya Authappan <rauthappan@gitlab.com> | 2019-09-06 09:20:06 +0000 |
|---|---|---|
| committer | Ramya Authappan <rauthappan@gitlab.com> | 2019-09-06 09:20:06 +0000 |
| commit | ec326ecf91e893531bc2412fd4177405911e0e98 (patch) | |
| tree | 1123d501eb85653b7ffde6795f5d4f96278d4532 /doc | |
| parent | 5b28b44fa30e26a83f5fe72d5015e6ad8fde841c (diff) | |
| parent | 88b727d7b7b6de4e388dba77cf05a3cfa26e8d7b (diff) | |
| download | gitlab-ce-ec326ecf91e893531bc2412fd4177405911e0e98.tar.gz | |
Merge branch 'qa-ml-approval-rules-tests' into 'master'
CE backport of EE MR approvals E2E test
See merge request gitlab-org/gitlab-ce!32439
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/development/testing_guide/end_to_end/page_objects.md | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/doc/development/testing_guide/end_to_end/page_objects.md b/doc/development/testing_guide/end_to_end/page_objects.md index 850ea6b60ac..8820b54fa87 100644 --- a/doc/development/testing_guide/end_to_end/page_objects.md +++ b/doc/development/testing_guide/end_to_end/page_objects.md @@ -167,6 +167,18 @@ There are two supported methods of defining elements within a view. Any existing `.qa-selector` class should be considered deprecated and we should prefer the `data-qa-selector` method of definition. +### Exceptions + +In some cases it might not be possible or worthwhile to add a selector. + +Some UI components use external libraries, including some maintained by third parties. +Even if a library is maintained by GitLab, the selector sanity test only runs +on code within the GitLab project, so it's not possible to specify the path for +the view for code in a library. + +In such rare cases it's reasonable to use CSS selectors in page object methods, +with a comment explaining why an `element` can't be added. + ## Running the test locally During development, you can run the `qa:selectors` test by running |