diff options
author | Phillip Johnsen <johphi@gmail.com> | 2019-05-10 22:53:02 +0000 |
---|---|---|
committer | Phillip Johnsen <johphi@gmail.com> | 2019-05-10 22:53:02 +0000 |
commit | 1dcc79cb094078d65e1a55dfb97e81005da82119 (patch) | |
tree | c0060a79c26f363b09858f42c2a971972d371f05 /doc | |
parent | 825b2bdafd76c1a6773f2ec2bf2b19487f64d4e7 (diff) | |
download | gitlab-ce-1dcc79cb094078d65e1a55dfb97e81005da82119.tar.gz |
Couple of improvements to the Vuex frontend guide
Two nitpick improvements to the following:
* set `state.isAddingUser = false` when request resulted in an error,
as it has finished after all
* be very explicit about vuex store being a local module to avoid confusion
about a dependency named `store`
Diffstat (limited to 'doc')
-rw-r--r-- | doc/development/fe_guide/vuex.md | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/doc/development/fe_guide/vuex.md b/doc/development/fe_guide/vuex.md index 7d52cac5f7e..bf248b7f8af 100644 --- a/doc/development/fe_guide/vuex.md +++ b/doc/development/fe_guide/vuex.md @@ -186,7 +186,7 @@ Remember that actions only describe that something happened, they don't describe state.users.push(user); }, [types.REQUEST_ADD_USER_ERROR](state, error) { - state.isAddingUser = true; + state.isAddingUser = false; state.errorAddingUser = error; }, }; @@ -231,7 +231,7 @@ The store should be included in the main component of your application: ```javascript // app.vue - import store from 'store'; // it will include the index.js file + import store from './store'; // it will include the index.js file export default { name: 'application', |