diff options
| author | Rémy Coutable <remy@rymai.me> | 2016-11-18 17:46:44 +0000 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2016-11-18 17:46:44 +0000 |
| commit | 03933cd279f0870a16f126619380ec386d68345a (patch) | |
| tree | b38581f3a13292be2c48eaeb99f8de7fd5b95770 /doc | |
| parent | a8a46e3d006bd06f2238b6487e1dad2f6f7d7dad (diff) | |
| parent | 9c4e0d64451bd76b829e1bb66afab892e19926da (diff) | |
| download | gitlab-ce-03933cd279f0870a16f126619380ec386d68345a.tar.gz | |
Merge branch 'fix-tests-for-different-host' into 'master'
Use `Gitlab.config.gitlab.host` over `'localhost'`
Use `Gitlab.config.gitlab.host` over `'localhost'`
This would fix long standing failures running tests on
my development machine, which set `Gitlab.config.gitlab.host`
to another host because it's not my local computer. Now I
finally cannot withstand it and decided to fix them once and
for all.
See merge request !7562
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/development/testing.md | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/doc/development/testing.md b/doc/development/testing.md index 4dc535fb359..6106e47daa0 100644 --- a/doc/development/testing.md +++ b/doc/development/testing.md @@ -70,6 +70,7 @@ the command line via `bundle exec teaspoon`, or via a web browser at - Try to match the ordering of tests to the ordering within the class. - Try to follow the [Four-Phase Test][four-phase-test] pattern, using newlines to separate phases. +- Try to use `Gitlab.config.gitlab.host` rather than hard coding `'localhost'` [four-phase-test]: https://robots.thoughtbot.com/four-phase-test |