diff options
| author | Yorick Peterse <yorickpeterse@gmail.com> | 2017-08-04 13:29:26 +0200 |
|---|---|---|
| committer | Yorick Peterse <yorickpeterse@gmail.com> | 2017-08-04 13:34:42 +0200 |
| commit | 9d3f27a22d0193de15cb40e5cab1c437c61eca69 (patch) | |
| tree | 5e76c07f8aecaff9c1c461b5688f8516280fa214 /doc | |
| parent | ea2d0c4861ef957cbcfe32a189d7d399c16241ae (diff) | |
| download | gitlab-ce-9d3f27a22d0193de15cb40e5cab1c437c61eca69.tar.gz | |
Removed commit guidelines for migrations
At some point we decided this isn't really necessary, so let's get rid
of it.
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/development/migration_style_guide.md | 13 |
1 files changed, 3 insertions, 10 deletions
diff --git a/doc/development/migration_style_guide.md b/doc/development/migration_style_guide.md index 161d2544169..5aac243ae3d 100644 --- a/doc/development/migration_style_guide.md +++ b/doc/development/migration_style_guide.md @@ -35,13 +35,6 @@ Please don't depend on GitLab-specific code since it can change in future versions. If needed copy-paste GitLab code into the migration to make it forward compatible. -## Commit Guidelines - -Each migration **must** be added in its own commit with a descriptive commit -message. If a commit adds a migration it _should only_ include the migration and -any corresponding changes to `db/schema.rb`. This makes it easy to revert a -database migration without accidentally reverting other changes. - ## Downtime Tagging Every migration must specify if it requires downtime or not, and if it should @@ -224,9 +217,9 @@ add_column(:projects, :foo, :integer, default: 10, limit: 8) ## Timestamp column type -By default, Rails uses the `timestamp` data type that stores timestamp data without timezone information. -The `timestamp` data type is used by calling either the `add_timestamps` or the `timestamps` method. -Also Rails converts the `:datetime` data type to the `timestamp` one. +By default, Rails uses the `timestamp` data type that stores timestamp data without timezone information. +The `timestamp` data type is used by calling either the `add_timestamps` or the `timestamps` method. +Also Rails converts the `:datetime` data type to the `timestamp` one. Example: |