diff options
| author | Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | 2015-03-26 18:27:49 +0000 |
|---|---|---|
| committer | Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | 2015-03-26 18:27:49 +0000 |
| commit | 090f2344ecb6631b20df5853045536f1eb0589d3 (patch) | |
| tree | 0b90225fcd4631f20732716683ee3c0997d82d66 /docker | |
| parent | a94f8a3c5e00f137eacfb7fda54157cb4fb77b5f (diff) | |
| parent | 8173ef976f91088d17b28a1581ab6fd80949e462 (diff) | |
| download | gitlab-ce-090f2344ecb6631b20df5853045536f1eb0589d3.tar.gz | |
Merge branch 'set-default-url-options' into 'master'
Set Application controller default URL options to ensure all url_for calls are consistent
### What does this MR do?
This MR sets the app controller's `default_url_options` so that all `url_for` calls are consistent.
### Are there points in the code the reviewer needs to double check?
Setting these options may simplify `url_for` calls that load the GitLab options already. I did not want to touch existing code yet. I'm also not sure if there are other options that need to be included.
### Why was this MR needed?
If you run GitLab behind a reverse proxy or in a Docker container, you don't want a user to be seeing the local IP and port on which GitLab is running (e.g. 192.168.1.1:8080). Right now there are places where this internal data is leaked (e.g. see the URL in Profile Settings -> Account -> Username; this uses `user_url`).
### What are the relevant issue numbers / [Feature requests](http://feedback.gitlab.com/)?
#1249
See merge request !453
Diffstat (limited to 'docker')
0 files changed, 0 insertions, 0 deletions