diff options
| author | Ryan Mendivil <rsmendivil@gmail.com> | 2013-09-10 17:36:04 -0800 |
|---|---|---|
| committer | Ryan Mendivil <rsmendivil@gmail.com> | 2013-09-11 18:53:37 -0800 |
| commit | 0a05ab9126aa1edadea069e9e7dbe272da4b9618 (patch) | |
| tree | 3f50efa2a0851848ca862dc62317bba598ac71a2 /features/project/commits | |
| parent | 7bf8d22f178d5628e9c2dc8e79ec94a016e1d69b (diff) | |
| download | gitlab-ce-0a05ab9126aa1edadea069e9e7dbe272da4b9618.tar.gz | |
Fix bug with rendering changing images in commits
When viewing the diff for a changed image file, two bugs occur:
- Both the 'before' and 'after' images link to the 'after' commit
- Visiting the link for either image will cause a error
The first is caused by both image links referencing '@commit.id' rather
than '@commit.parent_id'. The second is caused by the use of
'project_tree_path' which is used for creating links to directories in
the git file tree. 'project_blob_path' which links to files should be
used instead.
Diffstat (limited to 'features/project/commits')
| -rw-r--r-- | features/project/commits/commits.feature | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/features/project/commits/commits.feature b/features/project/commits/commits.feature index d962471ebdb..fe470f5ac99 100644 --- a/features/project/commits/commits.feature +++ b/features/project/commits/commits.feature @@ -35,3 +35,7 @@ Feature: Project Browse commits Scenario: I browse huge commit Given I visit huge commit page Then I see huge commit message + + Scenario: I browse a commit with an image + Given I visit a commit with an image that changed + Then The diff links to both the previous and current image |