diff options
| author | Ben Ford <ben.ford@puppetlabs.com> | 2015-10-19 14:52:46 -0700 |
|---|---|---|
| committer | Douwe Maan <douwe@gitlab.com> | 2015-10-29 15:49:07 +0100 |
| commit | 3be9d2c422b8651498abec3a2ee9bb6a3685f040 (patch) | |
| tree | 807a38b8b6e91319cc1b2ff8e2d31d0391f9ad59 /features/project/source | |
| parent | ae99720a40b8e0700891f5828c1a93bcc7673e04 (diff) | |
| download | gitlab-ce-3be9d2c422b8651498abec3a2ee9bb6a3685f040.tar.gz | |
Add ability to create directories in the editor
Simply type a name with a `/` directory separator and new directories
will be created. This does not do the fancy UI work that github.com
does, but it will get the job done.
I could not find tests for file creation, so I didn't add a test for
this slight behaviour modification. I did test directory traversals
though, using both absolute paths like `/tmp/foo.txt` and relative paths
like `../../foo.txt`. Neither case escaped the repository, though
attempting to traverse with a relative path resulted in a 500 error that
did not affect application stability upon reload.
Diffstat (limited to 'features/project/source')
| -rw-r--r-- | features/project/source/browse_files.feature | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/features/project/source/browse_files.feature b/features/project/source/browse_files.feature index 6b0484b6a38..69aa79f2d24 100644 --- a/features/project/source/browse_files.feature +++ b/features/project/source/browse_files.feature @@ -91,6 +91,16 @@ Feature: Project Source Browse Files And I see a commit error message @javascript + Scenario: I can create file with a directory name + Given I click on "New file" link in repo + And I fill the new file name with a new directory + And I edit code + And I fill the commit message + And I click on "Commit changes" + Then I am redirected to the new file with directory + And I should see its new content + + @javascript Scenario: I can edit file Given I click on ".gitignore" file in repo And I click button "Edit" |