summaryrefslogtreecommitdiff
path: root/features
diff options
context:
space:
mode:
authorKamil Trzciński <ayufan@ayufan.eu>2017-04-06 16:20:27 +0000
committerRémy Coutable <remy@rymai.me>2017-04-06 16:20:27 +0000
commit828d81ee1f6aaaf6ab9de1ed0c675ff961831c17 (patch)
treea8e9ba81f60e1185a86920ace8b9b2e9352e8ce9 /features
parent514dc1a0848616b93e8910c6c48eea4f64391884 (diff)
downloadgitlab-ce-828d81ee1f6aaaf6ab9de1ed0c675ff961831c17.tar.gz
Optimise trace handling code to use streaming instead of full read
Diffstat (limited to 'features')
-rw-r--r--features/steps/project/builds/summary.rb2
-rw-r--r--features/steps/shared/builds.rb2
2 files changed, 2 insertions, 2 deletions
diff --git a/features/steps/project/builds/summary.rb b/features/steps/project/builds/summary.rb
index 19ff92f6dc6..124582de6b9 100644
--- a/features/steps/project/builds/summary.rb
+++ b/features/steps/project/builds/summary.rb
@@ -22,9 +22,9 @@ class Spinach::Features::ProjectBuildsSummary < Spinach::FeatureSteps
end
step 'recent build has been erased' do
+ expect(@build).not_to have_trace
expect(@build.artifacts_file.exists?).to be_falsy
expect(@build.artifacts_metadata.exists?).to be_falsy
- expect(@build.trace).to be_empty
end
step 'recent build summary does not have artifacts widget' do
diff --git a/features/steps/shared/builds.rb b/features/steps/shared/builds.rb
index 5bc3a1f5ac4..5549fc25525 100644
--- a/features/steps/shared/builds.rb
+++ b/features/steps/shared/builds.rb
@@ -47,7 +47,7 @@ module SharedBuilds
end
step 'recent build has a build trace' do
- @build.trace = 'job trace'
+ @build.trace.set('job trace')
end
step 'download of build artifacts archive starts' do