diff options
| author | Robert Speicher <robert@gitlab.com> | 2016-03-21 14:42:25 +0000 |
|---|---|---|
| committer | Robert Speicher <robert@gitlab.com> | 2016-03-21 14:42:25 +0000 |
| commit | ffc3acd498e5cfeb98f6104421cba32acdd7ee64 (patch) | |
| tree | 7127c4a4b0221703dce53948d8de48bb2dd152bc /features | |
| parent | 3fca30d27f90a52bdbca746b1244c95e6c7db2d2 (diff) | |
| parent | 75aaf91cb1d08c4350e2881b18118faf30e1f310 (diff) | |
| download | gitlab-ce-ffc3acd498e5cfeb98f6104421cba32acdd7ee64.tar.gz | |
Merge branch 'issues-show-performance' into 'master'
Improve performance of viewing individual issues
This MR does two things:
1. `Issue#related_branches` no longer performs Git operations that aren't needed
2. The output of `Repository#exists?` is now cached and flushed properly
Combined these two changes should further cut down the amount of Git operations performed when viewing individual issues (and possibly other pages).
See merge request !3296
Diffstat (limited to 'features')
| -rw-r--r-- | features/project/issues/issues.feature | 1 | ||||
| -rw-r--r-- | features/steps/project/issues/issues.rb | 3 |
2 files changed, 3 insertions, 1 deletions
diff --git a/features/project/issues/issues.feature b/features/project/issues/issues.feature index ff21c7d1b83..de7e2b37725 100644 --- a/features/project/issues/issues.feature +++ b/features/project/issues/issues.feature @@ -160,6 +160,7 @@ Feature: Project Issues Scenario: Issues on empty project Given empty project "Empty Project" + And I have an ssh key When I visit empty project page And I see empty project details with ssh clone info When I visit empty project's issues page diff --git a/features/steps/project/issues/issues.rb b/features/steps/project/issues/issues.rb index 8c31fa890b2..aff5ca676be 100644 --- a/features/steps/project/issues/issues.rb +++ b/features/steps/project/issues/issues.rb @@ -5,6 +5,7 @@ class Spinach::Features::ProjectIssues < Spinach::FeatureSteps include SharedNote include SharedPaths include SharedMarkdown + include SharedUser step 'I should see "Release 0.4" in issues' do expect(page).to have_content "Release 0.4" @@ -240,7 +241,7 @@ class Spinach::Features::ProjectIssues < Spinach::FeatureSteps end step 'empty project "Empty Project"' do - create :empty_project, name: 'Empty Project', namespace: @user.namespace + create :project_empty_repo, name: 'Empty Project', namespace: @user.namespace end When 'I visit empty project page' do |