diff options
author | Jacob Schatz <jschatz@gitlab.com> | 2016-08-25 14:49:36 +0000 |
---|---|---|
committer | Jacob Schatz <jschatz@gitlab.com> | 2016-08-25 14:49:36 +0000 |
commit | 0b4fef6be48009404ac777034b0d61768b557673 (patch) | |
tree | fe011e23f53dbbe0c6a8fbfa6a0056a8af44fe51 /features | |
parent | a03da79fb2371ca0d866ce776bfb0bfe9f1be1df (diff) | |
parent | 96051549672084fabec9f67b1cf03c59e8ac3370 (diff) | |
download | gitlab-ce-0b4fef6be48009404ac777034b0d61768b557673.tar.gz |
Merge branch 'fix-hidden-discussion-permalinks' into 'master'
Automatically expand hidden discussions when accessed via a permalink hash (closes #19304)
## What does this MR do?
Addresses "Auto-expand a discussion note when we arrive via anchor" (issue #19304)
## Are there points in the code the reviewer needs to double check?
Let me know if the code is consistent with community standards (not 100% sure about indentation of chained jQuery actions)
I don't think this MR warrants any unit tests or documentation, but let me know if you disagree. I'll add the requisite CHANGELOG entry upon approval.
## Why was this MR needed?
Currently, if a discussion is accessed via a permalink to an "outdated" diff discussion, the anchor will not bring you to the expected part of the page.
## What are the relevant issue numbers?
#19304
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !5585
Diffstat (limited to 'features')
0 files changed, 0 insertions, 0 deletions